fix(TaskProcessing): Catch JSON encode errors in Manager#setTaskResult #46780
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyteinsky
approved these changes
Jul 26, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
marcelklehr
force-pushed
the
fix/taskprocessing-better-errors
branch
from
99b59da
to
714e495
Compare
Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
fix/taskprocessing-better-errors
branch
from
714e495
to
da34d4c
Compare
| @@ -865,7 +865,7 @@ | |||
| $task->setEndedAt(time()); | |||
| $error = 'The task was processed successfully but the provider\'s output doesn\'t pass validation against the task type\'s outputShape spec and/or the provider\'s own optionalOutputShape spec'; | |||
| $task->setErrorMessage($error); | |||
| $this->logger->error($error, ['exception' => $e]); | |||
| $this->logger->error($error . ' Output was: ' . var_export($result, true), ['exception' => $e]); | |||
Check failure
Code scanning / Psalm
TaintedHtml Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist